Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to KUKSA logo in Readme #10

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

SebastianSchildt
Copy link
Contributor

The logo in Pypi is broken, as the link was pointing to a Github page instead of an image directly.

See: https://pypi.org/project/kuksa-client/ (and when clicking "show image" on the roken link, you see the CDN complaining that a wrong content type is delivered)

This can also be seen when using .md preview in Visual Studio code: it is also broken there. Only GH WebUI was clever enough to fix this.

With the updated link it should work everywhere.

Signed-off-by: Sebastian Schildt <[email protected]>
Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see ...

@erikbosch erikbosch merged commit 4b5ae87 into eclipse-kuksa:main Dec 12, 2023
3 checks passed
@erikbosch erikbosch deleted the fix/Pypi_logo branch December 12, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants